Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toast): update toast design to match MD spec #16323

Merged
merged 10 commits into from Nov 14, 2018
Merged

fix(toast): update toast design to match MD spec #16323

merged 10 commits into from Nov 14, 2018

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Nov 14, 2018 •
edited

Short description of what this resolves:

Updates the Material Design Toast to closer match the spec: https://material.io/design/components/snackbars.html

Changes proposed in this pull request:

  • Updates the animation to use opacity, not translate
  • Updates design with the right background, box-shadow, etc.
  • Fixes the broken position middle of toast ([v4-beta.15] Toast middle = top #16271) and updates e2e test to include this
  • Allows for line breaks to be passed in the message

Ionic Version: 4.x

Fixes: #16271

master fix-toast-design
localhost_3333_src_components_toast_test_basic galaxy s5 5 localhost_3333_src_components_toast_test_basic galaxy s5 2

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 14, 2018
fix(toast): remove ability to pass html to message
f329bce 
out of scope of this PR, use text string instead
@brandyscarney
Copy link
Member Author

Good to merge once checks pass 👍

@brandyscarney brandyscarney merged commit 188a635 into master Nov 14, 2018
@brandyscarney brandyscarney deleted the fix-toast-design branch November 14, 2018 20:21
@paulstelzer paulstelzer mentioned this pull request Nov 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat manucorporat left review comments

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandyscarney @manucorporat