fix(refresher): check for cancelable before preventing default #17351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check before preventing event.
BoyeMagnus
changed the title
brandyscarney
changed the title
liamdebeasi
approved these changes
Feb 27, 2019
|
Thank you! |
|
No problem. Thanks for the merge 🙌 |
michaeltintiuc
pushed a commit
to ModusCreateOrg/ionic
that referenced
this pull request
Mar 4, 2019
…-team#17351) fixes ionic-team#15256 Add loading controller vue docs Add ion-tabs support, QOL fixes Fix @ionic/core version, rebuild core to include docs Update router
|
the same issue exists in the ion-slides ionic v 4.1.1 |
|
Hi there, Please open a new issue if you are running into an problem with Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check before preventing event.
Short description of what this resolves:
Resolves the following issue, where an error was thrown, because the event wasn't cancelable.
Changes proposed in this pull request:
Ionic Version: Latest
Fixes: #15256