Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): ng-add throws when not run against Angular CLI's initia… #17597

Merged
merged 3 commits into from Feb 27, 2019
Merged

fix(angular): ng-add throws when not run against Angular CLI's initia… #17597

merged 3 commits into from Feb 27, 2019

Conversation

ahasall
Copy link
Contributor

@ahasall ahasall commented Feb 24, 2019

…l app

closes #17596

Short description of what this resolves:

See #17596

Changes proposed in this pull request:

  • the location of the root module is parameterized

Ionic Version:

Fixes: #17596

@ionitron-bot ionitron-bot bot added the package: angular @ionic/angular package label Feb 24, 2019
mhartington
mhartington approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@mhartington mhartington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liamdebeasi liamdebeasi merged commit 484d92c into ionic-team:master Feb 27, 2019
@liamdebeasi
Copy link
Member

Thanks for the PR! 🎉

@ahasall
Copy link
Contributor Author

ahasall commented Feb 27, 2019

You're welcome.

@ahasall ahasall deleted the fix-ng-add-import-root-module branch February 27, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhartington mhartington mhartington approved these changes

Assignees
No one assigned
Labels
package: angular @ionic/angular package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng add works only when the project is in src
3 participants
@ahasall @liamdebeasi @mhartington