Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fab): disabled fab button no longer opens fab list #17620

Merged
merged 5 commits into from Mar 1, 2019
Merged

fix(fab): disabled fab button no longer opens fab list #17620

merged 5 commits into from Mar 1, 2019

Conversation

liamdebeasi
Copy link
Contributor

Short description of what this resolves:

This PR fixes an issue where the fab list was being opened even when ion-fab-button was disabled.

Changes proposed in this pull request:

  • Check to see if ion-fab-button is disabled before activating list
  • Added tests to make sure this doesn't come back as a regression

Ionic Version:

Fixes: #17599

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Feb 26, 2019
@liamdebeasi liamdebeasi merged commit c475dab into master Mar 1, 2019
@liamdebeasi liamdebeasi mentioned this pull request Mar 1, 2019
Closed
@brandyscarney brandyscarney deleted the fix-disabled-fab branch March 1, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamdebeasi @brandyscarney