Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix placeholder again #17774

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix placeholder again #17774

merged 1 commit into from
Mar 13, 2019

Conversation

liamdebeasi
Copy link
Contributor

Short description of what this resolves:

Fixes placeholders for Angular. undefined/null seem to be converts to empty strings in some cases

Changes proposed in this pull request:

  • Check for empty string

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 13, 2019
@liamdebeasi liamdebeasi merged commit f097276 into master Mar 13, 2019
@liamdebeasi liamdebeasi deleted the fix-datetime-placeholder-angular branch March 13, 2019 15:47
kiku-jw pushed a commit to kiku-jw/ionic that referenced this pull request May 16, 2019
@liamdebeasi @kiku-jw
fix(datetime): add additional checks for placeholders in angular (ion…
8b0bf35 
…ic-team#17774)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@liamdebeasi