feat(datetime): configurable timezone for display #19519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ionitron-bot
bot
added
package: angular
liamdebeasi
requested changes
Oct 7, 2019
I dont think its related because the picker above which does not use the displayTimezone does not show the 2020 either |
daem0ndev
force-pushed
the
feat-datetime-display-timezone
branch
from
1a0a44b
to
c22a9b5
Compare
|
Made the changes :) thanks! |
liamdebeasi
requested changes
Oct 8, 2019
daem0ndev
force-pushed
the
feat-datetime-display-timezone
branch
from
c22a9b5
to
9c2b125
Compare
daem0ndev
force-pushed
the
feat-datetime-display-timezone
branch
from
5c32af5
to
fb4421c
Compare
liamdebeasi
approved these changes
Jan 9, 2020
daem0ndev
force-pushed
the
feat-datetime-display-timezone
branch
from
fb4421c
to
62400c4
Compare
daem0ndev
force-pushed
the
feat-datetime-display-timezone
branch
from
62400c4
to
cfe569f
Compare
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently there is no way to override the behavior of the ion-datetime converting values to the users local timezone.
Issue Number: #19401
What is the new behavior?
displayTimezonepropertyDoes this introduce a breaking change?
Other information