Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(segment-button): allow min-width to be overridden #21722

Merged
merged 1 commit into from Jul 14, 2020
Merged

fix(segment-button): allow min-width to be overridden #21722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions core/src/components/segment-button/segment-button.md.scss
View file
Open in desktop
Expand Up @@ -44,11 +44,6 @@
text-transform: uppercase;
}

.button-native {
min-width: $segment-button-md-min-width;
}


// Segment Button: Disabled
// --------------------------------------------------

Expand Down
38 changes: 38 additions & 0 deletions core/src/components/segment/test/spec/index.html
View file
Open in desktop
Expand Up @@ -159,6 +159,40 @@
</ion-segment-button>
</ion-segment>

<!-- Non Scrollable, Custom Min Width -->
<ion-segment color="tertiary" value="heart" id="min-width-custom">
<ion-segment-button value="home">
<ion-icon name="home"></ion-icon>
</ion-segment-button>
<ion-segment-button value="heart">
<ion-icon name="heart"></ion-icon>
</ion-segment-button>
<ion-segment-button value="pin">
<ion-icon name="pin"></ion-icon>
</ion-segment-button>
<ion-segment-button value="star">
<ion-icon name="star"></ion-icon>
</ion-segment-button>
<ion-segment-button value="call">
<ion-icon name="call"></ion-icon>
</ion-segment-button>
<ion-segment-button value="globe">
<ion-icon name="globe"></ion-icon>
</ion-segment-button>
<ion-segment-button value="basket">
<ion-icon name="basket"></ion-icon>
</ion-segment-button>
<ion-segment-button value="airplane">
<ion-icon name="airplane"></ion-icon>
</ion-segment-button>
<ion-segment-button value="boat">
<ion-icon name="boat"></ion-icon>
</ion-segment-button>
<ion-segment-button value="baseball">
<ion-icon name="baseball"></ion-icon>
</ion-segment-button>
</ion-segment>

<!-- Scrollable Icons -->
<ion-segment scrollable color="tertiary" value="heart">
<ion-segment-button value="home">
Expand Down Expand Up @@ -212,6 +246,10 @@
</ion-content>

<style>
ion-segment#min-width-custom ion-segment-button {
min-width: auto;
}

ion-content {
--padding-top: 16px;
}
Expand Down