fix(toggle): properly announce toggle as switch with a label on screen readers #22477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't announce checkbox as being inside of another checkbox - properly announce when checked - expand footprint so the selected box surrounds the label too
brandyscarney
changed the title
|
Testing on my iPad, this announces toggle as checkbox |
7 tasks
TakumaKira
pushed a commit
to TakumaKira/ionic-framework
that referenced
this pull request
Nov 13, 2020
…n readers (ionic-team#22477) fixes ionic-team#22011 references ionic-team#21552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev build:
5.5.0-dev.202011111928.7c95d89fixes #21646 references #21552
Added a switch from the example here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Switch_role
Found our Toggle behaves the same way in macOS and iOS Safari, see the following: