Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): detail icon now respects rtl mode #23081

Merged
merged 1 commit into from Mar 22, 2021
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 22, 2021

Note: Stencil 2.5.0 brought some TypeScript changes that we need to investigate, but we are going to merge this PR for now to get the fix out.

See also: ionic-team/ionicons#954

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23078

What is the new behavior?

  • Bumped Ionicons version so detail icon now accounts for RTL mode

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Mar 22, 2021
@liamdebeasi liamdebeasi merged commit b04fb6e into master Mar 22, 2021
@liamdebeasi liamdebeasi deleted the ionicons-label-rtl branch March 22, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Detail Icon in RTL direction
1 participant