Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): support history@5 in preparation for react router 6 #23297

Merged
merged 2 commits into from May 14, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23294

What is the new behavior?

  • Ionic React now supports history@5x
  • Most developers will not notice a difference, and it is not currently recommended to use history@5 as react router expected history@4.x but react router 6 will support history@5 so we will need to add support anyways.
  • I opted to support both so we do not need to make any breaking changes right away (I.e. dropping support for react router 5)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: react @ionic/react package label May 12, 2021
@liamdebeasi liamdebeasi merged commit 4da5216 into master May 14, 2021
@liamdebeasi liamdebeasi deleted the react-history-5 branch May 14, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ionic react does not support history@5.x
1 participant