fix(item-sliding): prevent scrolling during slide gesture #23774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested changes
Aug 17, 2021
| @@ -252,7 +253,23 @@ export class ItemSliding implements ComponentInterface { | |||
| return !!(this.rightOptions || this.leftOptions); | |||
| } | |||
|
|
|||
| private toggleContentScrollY() { | |||
| const content = this.el.closest('ion-content'); | |||
There was a problem hiding this comment.
Can we grab the content in connectedCallback so that we do not need to query for it every time the gesture starts?
| private onStart() { | ||
| // Prevent scrolling during gesture | ||
| this.toggleContentScrollY(); |
There was a problem hiding this comment.
Any chance we could make these disable/enable functions rather than a toggle? I think it's a bit easier to read that way.
There was a problem hiding this comment.
Made this change and I agree it is much more readable, ty.
liamdebeasi
approved these changes
Aug 17, 2021
|
This fix has broken the smoothness of appearing/disappearing of the sliding items in ionic 5.6.14. Everything was good till 5.6.13 Screenshot attached item-sliding.mov |
|
Please open a new issue with a code reproduction, and we can take a look. |
|
Will do. Thanks |
This was referenced Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #19564
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #19564
What is the new behavior?
Does this introduce a breaking change?