Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): removed forced overscroll on non-scrollable popovers #23972

Merged
merged 1 commit into from Sep 23, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23971

Originally added in Ionic 3: https://github.com/ionic-team/ionic-v3/blame/2b7292e8a1187351fff9629bcef271d277abb318/src/components/select/select.scss#L7-L15

This allowed non-scrollable popovers to have a rubber band effect on iOS. Testing with a popover on the latest iOS indicates that non-scrollable popovers should not have a rubber band effect. (See https://www.hackingwithswift.com/quick-start/swiftui/how-to-show-a-popover-view for an example).

What is the new behavior?

  • Non-scrollable select popovers no longer rubber band
  • Note that this does not change behavior of popovers that use ion-content and have forceOverscroll="true".

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Remove margin from select popover.
1 participant