Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(img): draggable attribute is now inherited to inner img element #24781

Merged
merged 6 commits into from
Feb 21, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The draggable attribute does not get applied to the inner img tag within ion-img.

Issue URL: Resolves #21325

What is the new behavior?

The draggable attribute will be reflected to the inner img tag within ion-img.

  • Setting draggable="true" will allow the image to be draggable
  • Setting draggable="false" will disable the image from being draggable.
  • Not setting draggable will result in the default browser behavior of the image being draggable.

Does this introduce a breaking change?

  • Yes
  • No

Other information

This PR is in favor of #21686. Co-author credit has been applied to the commit.

Co-authored-by: Celilsemi Sam Erkiner <celilsemi@erkiner.com>
@sean-perkins sean-perkins requested a review from a team as a code owner February 14, 2022 18:39
@github-actions github-actions bot added the package: core @ionic/core package label Feb 14, 2022
@liamdebeasi liamdebeasi changed the title fix(img): draggable attribute reflects to img fix(img): draggable attribute is now inherited to inner img element Feb 15, 2022
@liamdebeasi
Copy link
Contributor

I pushed a commit that lets us avoid JSON.parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-img should accept draggable prop
3 participants