fix(alert): use aria-labelledby and aria-describedby instead of aria-label #25805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
In #25800, we added a default
aria-label
toion-alert
in order to resolve an Axe violation. However, there are two problems with this resolution:aria-label
of'Alert'
isn't any better than having no label at all, as it doesn't give any useful information. If anything, it can lead developers into a false sense of security due to the lack of Axe errors.alertdialog
role must also have anaria-describedby
attribute.Issue URL: N/A
What is the new behavior?
aria-label
replaced witharia-labelledby
andaria-describedby
. The former points to theheader
(or thesubHeader
if no header is defined), and the latter points to themessage
.message
), the attribute is left unset.Does this introduce a breaking change?
Other information
A separate PR will be put up to document this change and show best practices with accessibility.