Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetime): ionChange will only emit from user committed changes #26083

Merged
merged 20 commits into from
Oct 11, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 6, 2022

⚠️ Be sure to set commit message to the breaking change note when merging

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #20873, resolves #24452

What is the new behavior?

  • ionChange will now fire as a result of user-generated actions only.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Oct 6, 2022
@liamdebeasi liamdebeasi changed the title Fw 2031 feat(datetime): ionChange will only emit from user committed changes Oct 6, 2022
@github-actions github-actions bot added the package: angular @ionic/angular package label Oct 6, 2022
@github-actions github-actions bot added the package: vue @ionic/vue package label Oct 6, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review October 6, 2022 16:08
@liamdebeasi liamdebeasi requested a review from a team as a code owner October 6, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants