Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-button): nested interactives are not rendered #26576

Merged
merged 4 commits into from Jan 9, 2023
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 6, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #23332

This is the same issue as #26575.

What is the new behavior?

  • aria-selected and role states on ion-tab-button have been moved to the native <a> inside of the Shadow DOM.
  • aria-disabled has been added so screen readers can indicate that the tab button is disabled (This is a bug I discovered while fixing the original issue)
  • ariaLabel on ion-tab-button is now inherited to the native <a> element.
  • Added a11y test for tab button

Note: This has the same tradeoffs as #26575 re: Chrome + VoiceOver on macOS.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jan 6, 2023
@liamdebeasi liamdebeasi changed the title Fw 3113 fix(tab-button): nested interactives are not rendered Jan 6, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review January 6, 2023 19:13
@liamdebeasi liamdebeasi requested a review from a team as a code owner January 6, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: a11y, talkback reads tab button twice when swiping to go to next/previous tab button
2 participants