-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-router): migrate to eslint, add prettier #26634
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
liamdebeasi
changed the title
React router eslint new
chore(react-router): migrate to eslint, add prettier
Jan 18, 2023
liamdebeasi
commented
Jan 18, 2023
Comment on lines
-9
to
-17
- name: Install Dependencies | ||
run: npm install --legacy-peer-deps | ||
shell: bash | ||
working-directory: ./packages/react-router | ||
- uses: ./.github/workflows/actions/download-archive | ||
with: | ||
name: ionic-react | ||
path: ./packages/react | ||
filename: ReactBuild.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were duplicate commands that I removed
sean-perkins
approved these changes
Jan 18, 2023
13 tasks
amandaejohnston
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docs
repo, in a separate PR. See the contributing guide for details.npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
@ionic/react-router
has peer dependency issues when usingtslint
andtslint-ionic-rules
. This requires the use of--legacy-peer-deps
when releasing the package.What is the new behavior?
@ionic/react-router
from TSLint to ESLint and uses the Ionic ESLint config: https://github.com/ionic-team/eslint-config--legacy-peer-deps
flag and prefernpm ci
instead ofnpm install
Note: For ESLint I only used rules that likely would not cause any functional changes. We've been burned before with rules such as
prefer-optional-chain
causing functional changes. I also added several ignores to quirks in Ionic React such as how we use the spread operator to remove keys from the remaining object (but then never use the keys)Does this introduce a breaking change?
Other information