Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-router): migrate to eslint, add prettier #26634

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 18, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

@ionic/react-router has peer dependency issues when using tslint and tslint-ionic-rules. This requires the use of --legacy-peer-deps when releasing the package.

What is the new behavior?

Note: For ESLint I only used rules that likely would not cause any functional changes. We've been burned before with rules such as prefer-optional-chain causing functional changes. I also added several ignores to quirks in Ionic React such as how we use the spread operator to remove keys from the remaining object (but then never use the keys)

Does this introduce a breaking change?

  • Yes
  • No

Other information

@stackblitz
Copy link

stackblitz bot commented Jan 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@liamdebeasi liamdebeasi changed the title React router eslint new chore(react-router): migrate to eslint, add prettier Jan 18, 2023
@github-actions github-actions bot added the package: react @ionic/react package label Jan 18, 2023
Comment on lines -9 to -17
- name: Install Dependencies
run: npm install --legacy-peer-deps
shell: bash
working-directory: ./packages/react-router
- uses: ./.github/workflows/actions/download-archive
with:
name: ionic-react
path: ./packages/react
filename: ReactBuild.zip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were duplicate commands that I removed

@liamdebeasi liamdebeasi marked this pull request as ready for review January 18, 2023 17:22
@liamdebeasi liamdebeasi merged commit 6d4c52a into main Jan 18, 2023
@liamdebeasi liamdebeasi deleted the react-router-eslint-new branch January 18, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants