-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): transition animation plays when using browser back and forward buttons #28188
Closed
Closed
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9b00e20
fix(angular): fix navigation stack when using browser back and forwar…
philipp-stsm 64e0b44
fix(angular): remove legacy code for Angular < 7.2.0
philipp-stsm 9846503
fix(angular): update comment
philipp-stsm b7d25ea
revert: revert changes regarding navigation stack
philipp-stsm 887bad1
fix: apply fix for missing nav animation
philipp-stsm c36494b
revert: revert changes in stack controller
philipp-stsm bb91eb8
revert: revert changes for setting lastNavId
philipp-stsm e36e541
revert: revert unnecessary change
philipp-stsm 45ae7d3
Merge remote-tracking branch 'upstream/main' into fix-navigation
liamdebeasi 0f51294
Merge branch 'ionic-team:main' into fix-navigation
hoi4 b5f487c
fix: use root page transition when using root routerlink and browser …
philipp-stsm 9f2ea5a
chore: better semantic colocation of code
philipp-stsm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the timeout changes here necessary? If not, could we revert them? (Sorry, I meant to comment on this with my last round of reviews, but it slipped my mind)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if possible, could you allow me to push changes to your branch? I can resolve the merge conflicts for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it is necessary. Before, the back transition was instant and now it takes the time for the animation which is why we need the additional
wait
I invited you to my fork. Thanks for taking care of the merge conflicts.