-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(overlays): add Axe tests for color contrast #28630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandaejohnston
changed the title
test(overlays): add Axe tests (todo better title)
test(overlays): add Axe tests for color contrast
Dec 5, 2023
amandaejohnston
requested review from
liamdebeasi
and removed request for
a team
December 8, 2023 16:07
liamdebeasi
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One non-blocking suggestion and one question.
liamdebeasi
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
color-contrast
rule is disabled.What is the new behavior?
configs
blocks that test both light and dark themes. Markup has also been converted to usepage.setContent
instead ofpage.goto
to support automatic theme switching.color-contrast
rule re-enabled on action-sheet, alert, and toast. The rule was disabled due to contrast issues with the page content covered up by the backdrop, but with the new setup, the overlay is the only thing on the page.Does this introduce a breaking change?
Other information