Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(picker): add css variables for picker highlight and fade #28654

Merged
merged 11 commits into from Dec 11, 2023

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 6, 2023

Issue number: N/A


What is the current behavior?

Picker has the following CSS variables for styling: --wheel-fade-background-rgb and --wheel-highlight-background

These variables make sense when used from ion-datetime, but picker does not need the wheel prefix.

What is the new behavior?

Datetime

  • Adds --wheel-highlight-border-radius
  • Keeps --wheel-fade-background-rgb and --wheel-highlight-background
  • Assigns these variables to picker's new variables
ion-picker {
  --highlight-background: var(--wheel-highlight-background);
  --highlight-border-radius: var(--wheel-highlight-border-radius);
  --fade-background-rgb: var(--wheel-fade-background-rgb);
}

Picker

Renames --wheel-fade-background-rgb and --wheel-highlight-background and adds another CSS variables to ion-picker:

  • Renames --wheel-fade-background-rgb to --fade-background-rgb
  • Renames --wheel-highlight-background to --highlight-background
  • Adds --highlight-border-radius

Does this introduce a breaking change?

  • Yes
  • No

Other information

PR to update the Datetime docs

@github-actions github-actions bot added the package: core @ionic/core package label Dec 6, 2023
@brandyscarney brandyscarney marked this pull request as ready for review December 7, 2023 14:44
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions on the naming/how this is used in datetime

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@brandyscarney brandyscarney merged commit 5685a16 into FW-5575 Dec 11, 2023
54 checks passed
@brandyscarney brandyscarney deleted the FW-5582 branch December 11, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants