tests(many): add tests for color contrast for button components #28656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
requested changes
Dec 8, 2023
thetaPC
reviewed
Dec 8, 2023
liamdebeasi
approved these changes
Dec 12, 2023
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
Uses of
ion-color()in Button, Back Button, FAB, Menu Button, Item Option, and Segment do not have tests for color contrast.What is the new behavior?
ion-color()in Button, Back Button, FAB, Menu Button, Item Option, and Segment have tests for color contrast for both light and dark themes.Does this introduce a breaking change?
Other information