Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(many): add/update axe tests for form controls #28669

Merged
merged 19 commits into from
Dec 8, 2023
Merged

test(many): add/update axe tests for form controls #28669

merged 19 commits into from
Dec 8, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Dec 7, 2023 •
edited

Issue number: N/A

What is the current behavior?

Axe tests are not run for light/dark theme

What is the new behavior?

  • Re-enabled the color-contrast test for range. This was disabled due to a (now fixed) Axe bug.
  • Moved the HTML templates into setContent so we can more easily test light/dark mode
  • Added tests for each component such that the color palette is used. Checked states were added for checkbox, radio, and toggle. Focused states were added for input, textarea, and select. The value of the range was set to 50% so we can see more of the selected track.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Dec 7, 2023
liamdebeasi
liamdebeasi commented Dec 7, 2023
View reviewed changes
core/src/components/range/test/a11y/range.e2e.ts
/**
* Axe does not take <slot> elements into account
* when checking color-contrast. As a result, it will
* incorrectly report color-contrast issues: https://github.com/dequelabs/axe-core/issues/3329
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Axe issue was fixed earlier in 2023

@liamdebeasi liamdebeasi changed the title Fw 5636 test(many): add/update axe tests for form controls Dec 8, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review December 8, 2023 15:42
thetaPC
thetaPC approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi merged commit 31a8ef6 into FW-5584 Dec 8, 2023
44 checks passed
@liamdebeasi liamdebeasi deleted the FW-5636 branch December 8, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@amandaejohnston amandaejohnston Awaiting requested review from amandaejohnston

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamdebeasi @thetaPC