Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(high-contrast): add separate text and background step color variables #28797

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mapsandapps
Copy link
Contributor

Issue number: Internal


What is the current behavior?

Both the background color step variables and the text color step variables are based on the --ion-color-step- variables.

What is the new behavior?

  • The background color step variables are defined based on the --ion-background-color-step- values (not yet defined)
  • The text color step variables are defined based on the --ion-text-color-step- values (not yet defined)
  • The previous values remain as fallbacks

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jan 8, 2024
@mapsandapps mapsandapps marked this pull request as ready for review January 8, 2024 23:11
@mapsandapps mapsandapps requested a review from a team January 8, 2024 23:12
@mapsandapps mapsandapps merged commit f5df2a3 into FW-5747 Jan 9, 2024
44 checks passed
@mapsandapps mapsandapps deleted the FW-5829 branch January 9, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants