feat(toast): high contrast support for button text #28804
Merged
+88
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
| }); | ||
|
|
||
| test('should not have visual regressions', async ({ page }) => { |
There was a problem hiding this comment.
Do we need screenshot tests for this? I don't think we added any per-component screenshots for dark mode, since the color updates were handled in dedicated theme tests. (We should definitely keep the Axe test though.)
There was a problem hiding this comment.
ion-toast has custom styles for the different high contrast themes that are not covered by the theme tests.
There was a problem hiding this comment.
Ah, true! Fair enough 👍
amandaejohnston
approved these changes
Jan 10, 2024
brandyscarney
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
With the high contrast themes, the
ion-toastbuttons do not have sufficient color contrast to satisfy Level AAA.What is the new behavior?
ion-toastbuttons satisfy Level AAA color contrast with the high contrast themesDoes this introduce a breaking change?
Other information
Testing Locally
In
core/src/components/toast/test/buttons/index.htmladd the stylesheet import either the dark or light high contrast theme:Dark (high contrast):
Light (hight contrast):