Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react, react-router): build works on windows #28904

Merged
merged 2 commits into from
Jan 29, 2024
Merged

refactor(react, react-router): build works on windows #28904

merged 2 commits into from
Jan 29, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 29, 2024 •
edited
Loading

Issue number: Internal

What is the current behavior?

React and React Router packages do not build correctly on Windows because certain dependencies were not marked as external.

What is the new behavior?

  • 3rd party packages are correctly marked as external

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: react @ionic/react package label Jan 29, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review January 29, 2024 18:01
@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 29, 2024
Merged via the queue into main with commit b1c4c72 Jan 29, 2024
56 checks passed
@liamdebeasi liamdebeasi deleted the rollup-windows-fix branch January 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandaejohnston amandaejohnston amandaejohnston approved these changes

Assignees
No one assigned
Labels
package: react @ionic/react package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liamdebeasi @amandaejohnston