Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(action-sheet): use new step color tokens #28906

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Jan 29, 2024

Issue number: Internal


What is the current behavior?

Action sheet uses an --ion-color-step-* token directly. These tokens will be deprecated soon.

What is the new behavior?

New token added, while keeping the old one for backwards compatibility.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jan 29, 2024
@amandaejohnston amandaejohnston marked this pull request as ready for review January 30, 2024 15:47
@amandaejohnston amandaejohnston requested a review from a team as a code owner January 30, 2024 15:47
@amandaejohnston amandaejohnston requested review from mapsandapps and removed request for a team January 30, 2024 15:47
@amandaejohnston amandaejohnston changed the title fix(action-sheet): use new step color tokens refactor(action-sheet): use new step color tokens Jan 30, 2024
Copy link
Contributor

@mapsandapps mapsandapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@amandaejohnston amandaejohnston merged commit 7be84d2 into FW-5747 Jan 30, 2024
44 checks passed
@amandaejohnston amandaejohnston deleted the FW-5835 branch January 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants