Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): migrate step color usage #28910

Merged
merged 3 commits into from
Jan 30, 2024
Merged

refactor(datetime): migrate step color usage #28910

merged 3 commits into from
Jan 30, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jan 29, 2024

Issue number: internal


What is the current behavior?

Datetime is using the --ion-color-step-* directly. These tokens will be deprecated soon.

What is the new behavior?

  • Migrating to the new token, --ion-background-color-step-*, while still having the old token for backwards compatibility.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@github-actions github-actions bot added the package: core @ionic/core package label Jan 29, 2024
@thetaPC thetaPC marked this pull request as ready for review January 30, 2024 01:23
@thetaPC thetaPC merged commit 578f760 into FW-5747 Jan 30, 2024
44 checks passed
@thetaPC thetaPC deleted the FW-5838 branch January 30, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants