refactor(segment-button): update to use new step token #28925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandyscarney
requested review from
a team and
sean-perkins
and removed request for
a team
sean-perkins
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The segment button checked indicator only uses the
--ion-color-step-350variable with a fallback to the--ion-background-color.What is the new behavior?
The segment button checked indicator falls back to using the
--ion-background-color-step-350variable if it is defined but prioritizes--ion-color-step-350if it is also defined. This is the new step color token added for high-contrast themes.Does this introduce a breaking change?
Other information
No visual diffs are expected.