Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): add ionNavWillChange and ionNavDidChange types for nav #29122

Merged
merged 3 commits into from Mar 12, 2024
Merged

fix(angular): add ionNavWillChange and ionNavDidChange types for nav #29122

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3df428
fix(nav): add missing ionNavWillChange and ionNavDidChange types
sean-perkins Mar 7, 2024
4026335
chore: prettier
sean-perkins Mar 7, 2024
73f4cf3
chore: remove unneeded eslint rule
sean-perkins Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/angular/common/src/directives/navigation/nav.ts
View file
Open in desktop
@@ -1,4 +1,12 @@
import { ElementRef, Injector, EnvironmentInjector, NgZone, ChangeDetectorRef, Directive } from '@angular/core';
import {
ElementRef,
Injector,
EnvironmentInjector,
NgZone,
ChangeDetectorRef,
Directive,
EventEmitter,
} from '@angular/core';
import type { Components } from '@ionic/core';

import { AngularDelegate } from '../../providers/angular-delegate';
Expand All @@ -22,8 +30,16 @@ const NAV_METHODS = [
'getPrevious',
];

// eslint-disable-next-line @typescript-eslint/no-empty-interface
export declare interface IonNav extends Components.IonNav {}
export declare interface IonNav extends Components.IonNav {
/**
* Event fired when the nav will change components
*/
ionNavWillChange: EventEmitter<CustomEvent<void>>;
/**
* Event fired when the nav has changed components
*/
ionNavDidChange: EventEmitter<CustomEvent<void>>;
}

@ProxyCmp({
inputs: NAV_INPUTS,
Expand Down