fix(header): iOS headers in MD app are not hidden #29164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
amandaejohnston
and removed request for
a team
amandaejohnston
approved these changes
Mar 15, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28867
What is the current behavior?
I missed an edge case in #28277 that caused an MD headers in an MD app to be hidden due to the presence of an iOS header (via
mode="ios"). This was happening because I forgot to scope the selector inheader.ios.scssto only iOS headers.What is the new behavior?
Does this introduce a breaking change?
Other information
Dev build:
7.8.1-dev.11710452743.1ca99e5e