Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): add the large size for the ionic theme #29249

Merged
merged 6 commits into from Apr 3, 2024
Merged

Conversation

brandyscarney
Copy link
Member

Issue number: internal


What is the current behavior?

Input does not have a size property.

What is the new behavior?

  • Adds the size property with support for the "large" size on the "ionic" theme only
  • Adds tests for the size property
  • Note: the screenshots will not look right until the fill styles are added

Does this introduce a breaking change?

  • Yes
  • No

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Apr 1, 2024
@brandyscarney brandyscarney marked this pull request as ready for review April 1, 2024 22:20
core/src/components/input/input.tsx Outdated Show resolved Hide resolved
core/src/components/input/test/size/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified the size increase locally

@brandyscarney brandyscarney merged commit e965443 into ROU-4848 Apr 3, 2024
42 checks passed
@brandyscarney brandyscarney deleted the FW-6091 branch April 3, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants