-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): consolidate the developer resource files into a docs/ directory #29266
Conversation
β¦ting to docs directory
docs/_config.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is necessary for generating GitHub pages from the markdown files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could remove this if we want since we aren't deploying GitHub pages yet but I want to make sure we don't forget about it needing to be here when we do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration looks good, great work!
I don't have any blocking feedback. Docs content will be improved over time based on developer feedback and changes.
This is a big step in consolidating our information in one place, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we considered place the ToC on each page inside a expand?
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
I don't want to mess with the existing content of the documentation too much, unless it's very obviously outdated/incorrect information. I mainly want to get all of the files in one place and then we can iterate on the content after that. I am playing around with a Jekyll theme that will showcase our documentation with a side bar and it has a specific way of defining the table of contents so we might need to edit it for that also: https://just-the-docs.github.io/just-the-docs/docs/navigation-structure/#in-page-navigation-with-table-of-contents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just my comment about the links is left. I added my response.
Start your review here π docs/README.md
What is the current behavior?
Documentation files with information on how to contribute, component implementations, testing, etc. are scattered throughout various folders in this repository.
What is the new behavior?
Consolidates the documentation files into a root
docs/
directory for easier discovery and organization./docs
tree:Migrates the following:
.github/COMPONENT-GUIDE.md
docs/component-guide.md
.github/CONTRIBUTING.md
docs/CONTRIBUTING.md
core/scripts/README.md
docs/core/testing/preview-changes.md
core/src/utils/test/playwright/docs/api.md
docs/core/testing/api.md
core/src/utils/test/playwright/docs/best-practices.md
docs/core/testing/best-practices.md
core/src/utils/test/playwright/docs/README.md
docs/core/testing/README.md
core/src/utils/test/playwright/docs/usage-instructions.md
docs/core/testing/usage-instructions.md
packages/angular/test/README.md
docs/angular/testing.md
packages/react-router/test/README.md
docs/react-router/testing.md
packages/react/test/README.md
docs/react/testing.md
packages/react/test/base/README.md
docs/react/testing.md
packages/vue/test/README.md
docs/vue/testing.md
Adds the following:
docs/sass-guidelines.md
ionic-framework-design-documents
docs/README.md
docs/_config.yml
docs/core/README.md
docs/angular/README.md
docs/react/README.md
docs/react-router/README.md
docs/vue/README.md
docs/vue-router/README.md
docs/vue-router/testing.md
Does not add any files for
angular-server
. This is because the README is essentially empty and there is no testing in that directory. I can add blank files if we want to have something to add to later.Does not migrate the content of the packages' root
README.md
files. These files are used for their npm package descriptions so we should not edit them.Hosting Documentation
We can (and should) host these files using GitHub Pages. I have duplicated them in a personal repository to see how this would look: docs-consolidation.
Doing so will require some formatting fixes (see Sass Guidelines) so I did not publish them now but we can easily enable GitHub pages by toggling a setting in this repository.
Other information
*.md
files in a directory:find core/src -type f -name "*.md" -print
find packages/angular -type f -name "*.md" -not -path "**/node_modules/*" -print