Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): consolidate the developer resource files into a docs/ directory #29266

Merged
merged 17 commits into from
Apr 8, 2024

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Apr 3, 2024

Start your review here πŸ‘‰ docs/README.md

What is the current behavior?

Documentation files with information on how to contribute, component implementations, testing, etc. are scattered throughout various folders in this repository.

What is the new behavior?

Consolidates the documentation files into a root docs/ directory for easier discovery and organization.

/docs tree:

β”œβ”€β”€ _config.yml
β”œβ”€β”€ component-guide.md
β”œβ”€β”€ CONTRIBUTING.md
β”œβ”€β”€ README.md
β”œβ”€β”€ sass-guidelines.md
β”œβ”€β”€ angular
β”‚Β Β  β”œβ”€β”€ README.md
β”‚Β Β  └── testing.md
β”œβ”€β”€ core
β”‚Β Β  β”œβ”€β”€ README.md
β”‚Β Β  └── testing
β”‚Β Β      β”œβ”€β”€ README.md
β”‚Β Β      β”œβ”€β”€ api.md
β”‚Β Β      β”œβ”€β”€ best-practices.md
β”‚Β Β      β”œβ”€β”€ preview-changes.md
β”‚Β Β      └── usage-instructions.md
β”œβ”€β”€ react
β”‚Β Β  β”œβ”€β”€ README.md
β”‚Β Β  └── testing.md
β”œβ”€β”€ react-router
β”‚Β Β  β”œβ”€β”€ README.md
β”‚Β Β  └── testing.md
β”œβ”€β”€ vue
β”‚Β Β  β”œβ”€β”€ README.md
β”‚Β Β  └── testing.md
└── vue-router
    β”œβ”€β”€ README.md
    └── testing.md

Migrates the following:

Previous Location New Location
.github/COMPONENT-GUIDE.md docs/component-guide.md
.github/CONTRIBUTING.md docs/CONTRIBUTING.md
core/scripts/README.md docs/core/testing/preview-changes.md
core/src/utils/test/playwright/docs/api.md docs/core/testing/api.md
core/src/utils/test/playwright/docs/best-practices.md docs/core/testing/best-practices.md
core/src/utils/test/playwright/docs/README.md docs/core/testing/README.md
core/src/utils/test/playwright/docs/usage-instructions.md docs/core/testing/usage-instructions.md
packages/angular/test/README.md docs/angular/testing.md
packages/react-router/test/README.md docs/react-router/testing.md
packages/react/test/README.md docs/react/testing.md
packages/react/test/base/README.md docs/react/testing.md
packages/vue/test/README.md docs/vue/testing.md

Adds the following:

File Description
docs/sass-guidelines.md Sass Variable guidelines taken from ionic-framework-design-documents
docs/README.md Entry file that should link to all other files
docs/_config.yml Config file for use with GitHub pages
docs/core/README.md Description of core, links to contributing and testing
docs/angular/README.md Description of angular, links to contributing and testing
docs/react/README.md Description of react, links to contributing and testing
docs/react-router/README.md Description of react-router, links to contributing and testing
docs/vue/README.md Description of vue, links to contributing and testing
docs/vue-router/README.md Description of vue-router, links to contributing and testing
docs/vue-router/testing.md Testing file for vue-router, populated from vue-router's main README

Does not add any files for angular-server. This is because the README is essentially empty and there is no testing in that directory. I can add blank files if we want to have something to add to later.

Does not migrate the content of the packages' root README.md files. These files are used for their npm package descriptions so we should not edit them.

Hosting Documentation

We can (and should) host these files using GitHub Pages. I have duplicated them in a personal repository to see how this would look: docs-consolidation.

Doing so will require some formatting fixes (see Sass Guidelines) so I did not publish them now but we can easily enable GitHub pages by toggling a setting in this repository.

Other information

  • Verify that no documentation files were missed in the migration
    • You can use these commands to search for *.md files in a directory:
      • find core/src -type f -name "*.md" -print
      • find packages/angular -type f -name "*.md" -not -path "**/node_modules/*" -print
    • I did add some redirect links in some of the existing markdown files so they might still exist for that reason
  • We should probably break up the contributing + component guide documentation into smaller files, such as including best practices, but I wanted to get everything in the same place first

@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Apr 3, 2024
@github-actions github-actions bot added package: angular @ionic/angular package package: react @ionic/react package labels Apr 4, 2024
docs/_config.yml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is necessary for generating GitHub pages from the markdown files

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could remove this if we want since we aren't deploying GitHub pages yet but I want to make sure we don't forget about it needing to be here when we do

docs/core/testing.md Outdated Show resolved Hide resolved
docs/sass-guidelines.md Outdated Show resolved Hide resolved
@brandyscarney brandyscarney changed the title chore(docs): move contributing and component guide docs chore(docs): consolidate the developer resource files into a docs/ directory Apr 4, 2024
@brandyscarney brandyscarney marked this pull request as ready for review April 4, 2024 22:16
@brandyscarney brandyscarney requested review from thetaPC and a team as code owners April 4, 2024 22:16
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
docs/sass-guidelines.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration looks good, great work!

I don't have any blocking feedback. Docs content will be improved over time based on developer feedback and changes.

This is a big step in consolidating our information in one place, thank you!

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we considered place the ToC on each page inside a expand?

docs/core/testing/preview-changes.md Outdated Show resolved Hide resolved
docs/core/testing/preview-changes.md Show resolved Hide resolved
docs/core/testing/preview-changes.md Show resolved Hide resolved
docs/core/testing/preview-changes.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
core/scripts/readme.md Outdated Show resolved Hide resolved
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@brandyscarney
Copy link
Member Author

Have we considered place the ToC on each page inside a expand?

I don't want to mess with the existing content of the documentation too much, unless it's very obviously outdated/incorrect information. I mainly want to get all of the files in one place and then we can iterate on the content after that. I am playing around with a Jekyll theme that will showcase our documentation with a side bar and it has a specific way of defining the table of contents so we might need to edit it for that also: https://just-the-docs.github.io/just-the-docs/docs/navigation-structure/#in-page-navigation-with-table-of-contents

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just my comment about the links is left. I added my response.

@brandyscarney brandyscarney added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@brandyscarney brandyscarney added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@thetaPC thetaPC added this pull request to the merge queue Apr 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 8, 2024
@brandyscarney brandyscarney added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit b315b0c Apr 8, 2024
46 checks passed
@brandyscarney brandyscarney deleted the FW-6107 branch April 8, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants