fix(input): update helper text color for ionic theme #29269
Conversation
There was a problem hiding this comment.
The input snapshots look plain because this PR only focuses on the helper text.
| @@ -53,7 +53,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => | |||
| /** | |||
| * Rendering is the same across modes | |||
| */ | |||
| configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | |||
| configs({ modes: ['md', 'ionic-md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | |||
There was a problem hiding this comment.
I decided to reuse these tests since at some point, the ionic theme will implement the helper text and error text and these tests are testing exactly what needs to be checked.
There was a problem hiding this comment.
This screenshots were generated because ionic-md was added to an existing test. These screenshots will be changed through a different PR that works on the error text.
| @@ -36,6 +36,31 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => { | |||
| }); | |||
| }); | |||
|
|
|||
| configs({ directions: ['ltr'], modes: ['ionic-md'] }).forEach(({ title, screenshot, config }) => { | |||
| test.describe(title('input: bottom content'), () => { | |||
There was a problem hiding this comment.
ionic theme input does not have a solid fill so we don't test it.
There was a problem hiding this comment.
The error text screenshots are being generated because ionic-md was added to an existing test. These screenshots will be updated through another PR that implements the ionic theme for the error text.
There was a problem hiding this comment.
The error text screenshots are being generated because ionic-md was added to an existing test. These screenshots will be updated through another PR that implements the ionic theme for the error text.
thetaPC
changed the title
Issue number: internal
What is the current behavior?
The helper text has already been implemented. However, the color does not match the design for the
ionictheme.What is the new behavior?
ionictheme.ionic-md.ionicdesign tokens are set.Does this introduce a breaking change?
Other information
The input snapshots look plain because this PR only focuses on the helper text.