Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): update error text color for ionic theme #29270

Merged
merged 3 commits into from Apr 4, 2024
Merged

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Apr 3, 2024

Issue number: internal


What is the current behavior?

The error text has already been implemented. However, the color does not match the design for the ionic theme.

What is the new behavior?

  • The error text color has been updated to match the design for the ionic theme.
  • The bottom content input test has been adjusted to include ionic-md.
  • The color was hard coded until the ionic design tokens are set.

Does this introduce a breaking change?

  • Yes
  • No

Other information

The input snapshots look plain because this PR only focuses on the error text.

@github-actions github-actions bot added the package: core @ionic/core package label Apr 3, 2024
@thetaPC thetaPC changed the base branch from main to ROU-4848 April 3, 2024 23:39
@thetaPC thetaPC changed the title Fw 6088 refactor(input): update error text color for ionic theme Apr 3, 2024
@thetaPC thetaPC changed the title refactor(input): update error text color for ionic theme fix(input): update error text color for ionic theme Apr 3, 2024
@thetaPC thetaPC marked this pull request as ready for review April 3, 2024 23:40
@thetaPC thetaPC requested a review from a team as a code owner April 3, 2024 23:40
@thetaPC thetaPC requested review from brandyscarney and removed request for a team April 3, 2024 23:40
@thetaPC thetaPC merged commit 5b62a1e into ROU-4848 Apr 4, 2024
42 checks passed
@thetaPC thetaPC deleted the FW-6088 branch April 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants