feat(input): add styles for clear action to ionic theme #29337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amandaejohnston
changed the title
|
The input UX requirements were updated to change all references to the Active state to just be when the input is focused. Updated the PR description to remove extra notes about what Active means. |
|
@amandaejohnston please update the description with the new logic for the visibility of the clear icon. |
The logic used here hasn't actually changed (it was always equivalent to the input being focused), so no updates needed on that front 👍 |
thetaPC
reviewed
Apr 15, 2024
thetaPC
requested changes
Apr 15, 2024
This reverts commit 3bec67f.
This reverts commit ee8fa3c.
thetaPC
requested changes
Apr 15, 2024
thetaPC
approved these changes
Apr 16, 2024
Good idea, added 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the new behavior?
For the
ionictheme: Adjusted the size of the clear button to match design specs, and updated the behavior so the button additionally only shows if the native input or any other actions within theion-inputare focused. (See code comments for details.)The actual icon used has not been modified. The ticket says to "use the material design clear icon as the reference icon for this feature," and we've already added a feature allowing the icon to be customized at the app level. Let me know if the intention was to use a different default icon with the
ionictheme.Does this introduce a breaking change?
Other information