Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic font scaling for iOS Picker component #29341

Closed
wants to merge 1 commit into from

Conversation

Kuldeepdev
Copy link

Issue number: resolves # 29340


What is the current behavior?

Ionic Picker component do not
respond to font scaling on iOS which can create inaccessible
applications particularly for users with low vision for Picker component. 
Ionic apps on
Android devices currently support the Android equivalent due to
functionality in the Chromium webview.
Developers have also requested a way of adjusting the fonts in their
Ionic Picker component consistently.

What is the new behavior?

  • Ionic Picker components now use dynamic-font function in scss file. This
means devs can change the font size on html and the text in supported
Ionic Picker components will scale up/down appropriately
  • Add support for Dynamic Type on iOS (the iOS version of Dynamic Font
Scaling) for Picker Component.

Does this introduce a breaking change?

  • Yes
  • [X ] No

Other information

Code Reproduction:
https://github.com/Kuldeepdev/picker-dynamic-font/tree/main

@Kuldeepdev Kuldeepdev requested a review from a team as a code owner April 15, 2024 12:34
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 0:36am

@thetaPC
Copy link
Contributor

thetaPC commented Apr 17, 2024

Thanks for submitting the PR!

This PR will be closed as we're maintaining alignment with iOS's picker structure, which doesn't include font scaling. However, you can still customize elements within ion-picker to scale along with fonts in your app.

.picker-col .picker-opt,
.picker-col .picker-prefix,
.picker-col .picker-suffix {
  font-size: 1.25rem;
}

.picker-toolbar .picker-button
 .picker-toolbar .picker-button.ion-activated {
  font-size: 0.875rem;
}

@thetaPC thetaPC closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants