fix(input): debounce is set with binding syntax in angular on load #29377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
liamdebeasi
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #29374
What is the current behavior?
When using Angular binding syntax, the
debouncevalue can be set afterconnectedCallback, but beforecomponentDidLoad. This results in the internal representation of thedebouncevalue to be the default and the watch callback to never fire.What is the new behavior?
debounceis called on component load, identical to what we do for the same exact reasons for the inputtype.debouncewill correctly reflect and apply the developers value when using binding syntax on initial loadDoes this introduce a breaking change?
Other information
Dev-build:
8.0.1-dev.11713879639.102f51a0Forked reproduction with the dev-build is available here: #29374 (comment)