Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update stencil to v4.17.1 #29384

Merged
merged 1 commit into from
Apr 23, 2024
Merged

chore(deps): update stencil to v4.17.1 #29384

merged 1 commit into from
Apr 23, 2024

Conversation

sean-perkins
Copy link
Contributor

Issue number: N/A

What is the current behavior?

What is the new behavior?

  • Updates to the latest version of Stencil
    • Includes a fix for the api.txt diff issue we are experiencing off next

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 8:56pm

@github-actions github-actions bot added the package: core @ionic/core package label Apr 23, 2024
@sean-perkins sean-perkins marked this pull request as ready for review April 23, 2024 20:57
@sean-perkins sean-perkins requested a review from a team as a code owner April 23, 2024 20:57
@sean-perkins sean-perkins removed the request for review from amandaejohnston April 23, 2024 20:58
thetaPC
thetaPC approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney mentioned this pull request Apr 23, 2024
Closed
@sean-perkins sean-perkins added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit b76debe Apr 23, 2024
46 checks passed
@sean-perkins sean-perkins deleted the sp/bump-stencil branch April 23, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sean-perkins @liamdebeasi @brandyscarney @thetaPC