Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade stencil to v4.17.2 #29416

Merged
merged 1 commit into from Apr 29, 2024
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Apr 29, 2024

Issue number: resolves #29393


What is the current behavior?

With Stencil v4.17.1, in Angular apps Stencil's MockDoc will be bundled with the consumer's code resulting in a significant increase to the main chunk.

v8.0.0
CleanShot 2024-04-29 at 11 14 36@2x
v8.0.1
CleanShot 2024-04-29 at 11 15 38@2x

What is the new behavior?

  • Updates to v4.17.2 of Stencil, which resolves this regression 🎉
Dev-build
CleanShot 2024-04-29 at 11 17 50@2x

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 8.0.2-dev.11714402065.169342dc

This patch release of Stencil addresses a bundle size increase due to Stencil bundling MockDoc in consumer apps in Angular.

Reference issue: #29393
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview Apr 29, 2024 3:08pm

@github-actions github-actions bot added the package: core @ionic/core package label Apr 29, 2024
@sean-perkins sean-perkins marked this pull request as ready for review April 29, 2024 15:29
@sean-perkins sean-perkins requested a review from a team as a code owner April 29, 2024 15:29
@sean-perkins sean-perkins added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit aebf694 Apr 29, 2024
56 checks passed
@sean-perkins sean-perkins deleted the sp/upgrade-stencil branch April 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: bundle size increase with IonicModule and lazy loaded web components in v8.0.1
2 participants