Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): set active segment button when dynamically changing items #29418

Merged
merged 3 commits into from
May 1, 2024

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Apr 29, 2024

Issue number: resolves #29414


What is the current behavior?

In Angular when the segment buttons are dynamically rendered, the segment will not set the active visual state for the selected segment after the re-render.

What is the new behavior?

  • In Angular the segment will set the active item visually when the items are dynamically changed

Previously this PR: #28837 aimed to resolve #28816. I have confirmed that the modified approach in the dev-build fixes #29414 and #28816 and the previous change is no longer needed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 8.0.2-dev.11714411675.10f48160

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 2:26pm

@github-actions github-actions bot added the package: core @ionic/core package label Apr 29, 2024
@sean-perkins sean-perkins marked this pull request as ready for review April 29, 2024 18:00
@sean-perkins sean-perkins requested a review from a team as a code owner April 29, 2024 18:00
Copy link
Contributor

@jakobe jakobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the mentioned issue 👍🏻

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit ee83388 May 1, 2024
46 checks passed
@sean-perkins sean-perkins deleted the sp/FW-6209 branch May 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
3 participants