fix(input): implement default shape for ionic theme #29469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
commented
May 6, 2024
| @@ -44,38 +44,17 @@ configs({ modes: ['md'] }).forEach(({ title, screenshot, config }) => { | |||
| const input = page.locator('ion-input'); | |||
| await expect(input).toHaveScreenshot(screenshot(`input-fill-solid-label-floating`)); | |||
| }); | |||
| test('should not have visual regressions with shaped solid', async ({ page }) => { | |||
There was a problem hiding this comment.
Removed these tests and their snapshots because I moved them under the newly made shape folder.
thetaPC
commented
May 6, 2024
| const input = page.locator('ion-input'); | ||
| await expect(input).toHaveScreenshot(screenshot(`input-fill-shaped-solid`)); | ||
| }); | ||
| test('padding and border radius should be customizable', async ({ page }) => { |
There was a problem hiding this comment.
The border radius customization will be tested under the newly made shape folder.
thetaPC
commented
May 6, 2024
| private getShape() { | ||
| const theme = getIonTheme(this); | ||
| const { shape } = this; | ||
| if (theme === 'ios' && shape === 'round') { |
There was a problem hiding this comment.
It's not possible to have a round shape for the ios theme since it doesn't support an outline. I decided to add a warning.
...ut/test/fill/input.e2e.ts-snapshots/input-fill-outline-custom-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
thetaPC
commented
May 8, 2024
There was a problem hiding this comment.
These will look like md theme since the default style hasn't been implemented.
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Input doesn't provide a default shape.
What is the new behavior?
mdandionicdefaults toround.ioshas yet to be determined, this will be done at a later time.Does this introduce a breaking change?
Other information
Preview