fix(input): only apply the shape to the outline fill in ionic theme #29482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
brandyscarney
commented
May 9, 2024
|
|
||
| :host(.input-fill-outline.input-disabled) { |
There was a problem hiding this comment.
This can be removed because it is covered by the :host(.input-disabled) class since I moved the --background variable assignment to the proper element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The shape styles are being applied when the
fillis unset in theionictheme. This is incorrect per the input UX requirements as shape should only apply whenfillis set to"outline". This is made apparent when looking at the existing styles fordisabled.What is the new behavior?
"outline"fill--backgroundcss variable to the native wrapper since this is what we use to style both the disabled and readonly statesI am not sure why this wasn't caught with the shape additions, but it's probably because the minimum pixel ratio was not met.
Does this introduce a breaking change?
Other information
Preview