Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tokens): add new tokens json files #29525

Merged
merged 41 commits into from
May 22, 2024
Merged

feat(tokens): add new tokens json files #29525

merged 41 commits into from
May 22, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 20, 2024

Issue number: internal


What is the new behavior?

  • Added new structure of JSON files that are generated from Figma Variables
  • Adjusted tokens.js script to correctly translate the new JSON format
  • Adjusted tokens usage on components and CSS files
  • Added html template to auto-generate html preview based on Design Tokens (wip)
  • Updated snapshots, as some tokens values changed, specially colors.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels May 20, 2024
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 20, 2024 13:31
@BenOsodrac BenOsodrac requested a review from thetaPC May 20, 2024 13:31
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:04am

@BenOsodrac
Copy link
Contributor Author

BenOsodrac commented May 21, 2024

@thetaPC @brandyscarney I did some recent commits to reorganize the tokens.js code a bit better and separate some methods on a different file. Hopefully its a bit cleaner 👍 .

Also, these introduced expected differences on some of the components already done for new framework. I will be reviewing those styles either way this sprint, as there were some UI adjustments done by the UX team in the past weeks.

Unless you find some extremely wrong, I would say we commit for now for these changes (slight color changes and border values), so that we can start all working on the same base Design Tokens 💪

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all the comments!

core/scripts/tokens/preview-template.html Outdated Show resolved Hide resolved
core/.eslintignore Outdated Show resolved Hide resolved
core/scripts/tokens/preview-styles.css Outdated Show resolved Hide resolved
core/.stylelintrc.yml Outdated Show resolved Hide resolved
core/scripts/tokens/tokens.js Outdated Show resolved Hide resolved
core/scripts/tokens/tokens-utilities.js Outdated Show resolved Hide resolved
core/scripts/tokens/tokens-utilities.js Outdated Show resolved Hide resolved
core/scripts/tokens/tokens-utilities.js Outdated Show resolved Hide resolved
core/scripts/tokens/tokens-utilities.js Outdated Show resolved Hide resolved
core/scripts/tokens/tokens-utilities.js Outdated Show resolved Hide resolved
core/scripts/tokens/index.js Outdated Show resolved Hide resolved
core/scripts/tokens.js Outdated Show resolved Hide resolved
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!!

@BenOsodrac BenOsodrac merged commit b6325e4 into next May 22, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-4870 branch May 22, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants