-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tokens): add new tokens json files #29525
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@thetaPC @brandyscarney I did some recent commits to reorganize the tokens.js code a bit better and separate some methods on a different file. Hopefully its a bit cleaner 👍 . Also, these introduced expected differences on some of the components already done for new framework. I will be reviewing those styles either way this sprint, as there were some UI adjustments done by the UX team in the past weeks. Unless you find some extremely wrong, I would say we commit for now for these changes (slight color changes and border values), so that we can start all working on the same base Design Tokens 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all the comments!
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!!
Issue number: internal
What is the new behavior?
Does this introduce a breaking change?
Other information