feat(badge): add small/default size for ionic theme #29526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: core
BenOsodrac
requested changes
May 21, 2024
|
@BenOsodrac please check the badge again, I added some styles that I missed the first time. |
BenOsodrac
requested changes
May 21, 2024
| @@ -0,0 +1,29 @@ | |||
| @use "../../foundations/ionic.vars.scss" as tokens; | |||
There was a problem hiding this comment.
We should instead change this to @use "../../themes/ionic/ionic.globals.scss" as globals;. This new approach was suggested after the creation of the ionic.globals.scss partial, that already forwards all the necessary tokens for Ionic Theme
There was a problem hiding this comment.
This is detailed on the foundations ReadME: https://github.com/ionic-team/ionic-framework/blob/next/core/src/foundations/README.md#how-to-use
BenOsodrac
approved these changes
May 22, 2024
brandyscarney
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Badge does not have a size prop.
What is the new behavior?
ionicthemeDoes this introduce a breaking change?
Other information
Preview