Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): add large size for ionic theme #29529

Merged
merged 20 commits into from
May 22, 2024
Merged

feat(badge): add large size for ionic theme #29529

merged 20 commits into from
May 22, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented May 21, 2024

Issue number: internal


What is the current behavior?

Badge does not have a large size.

What is the new behavior?

  • Added the large size for the ionic theme.
  • Added tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 6:43pm

@github-actions github-actions bot added the package: core @ionic/core package label May 21, 2024
@thetaPC thetaPC marked this pull request as ready for review May 21, 2024 21:21
@thetaPC thetaPC requested a review from a team as a code owner May 21, 2024 21:21
@thetaPC thetaPC requested review from brandyscarney and removed request for a team May 21, 2024 21:21
@thetaPC thetaPC changed the title feat(badge): add large size feat(badge): add large size for ionic theme May 21, 2024
Base automatically changed from ROU-10725 to next May 22, 2024 18:11
@thetaPC thetaPC merged commit 258dabf into next May 22, 2024
46 checks passed
@thetaPC thetaPC deleted the ROU-10727 branch May 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants