Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens): update design-tokens #29533

Merged
merged 3 commits into from
May 22, 2024
Merged

feat(tokens): update design-tokens #29533

merged 3 commits into from
May 22, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 22, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

Added an update to Design Tokens, requested by UX/UI Team:

  • New semantic colors added
  • Guidelines token was removed
  • Hover, disabled and pressed tokens now correctly appear on Theme JSON
  • Removed color.styles.tokens.json file, as it was now empty.

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels May 22, 2024
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 22, 2024 16:51
@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:55pm

thetaPC
thetaPC approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit 888b0c8 into next May 22, 2024
47 checks passed
@BenOsodrac BenOsodrac deleted the update-tokens branch May 22, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@brandyscarney brandyscarney Awaiting requested review from brandyscarney brandyscarney is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenOsodrac @thetaPC