Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar): add styles for large size in ionic theme #29541

Merged
merged 19 commits into from
May 23, 2024
Merged

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented May 22, 2024

Issue number: internal


What is the current behavior?

Avatar does not have styles for the "large" size in the ionic theme.

What is the new behavior?

  • Adds the styles for the large size (width, height, padding, font size)
  • Adds e2e test for large size to the existing avatar test for sizes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 4:33pm

@brandyscarney brandyscarney marked this pull request as ready for review May 22, 2024 22:10
@brandyscarney brandyscarney requested a review from a team as a code owner May 22, 2024 22:10
@brandyscarney brandyscarney requested review from thetaPC and removed request for a team May 22, 2024 22:10
Base automatically changed from ROU-10735 to next May 23, 2024 16:12
@brandyscarney brandyscarney merged commit 7f8be3e into next May 23, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-10736 branch May 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants