feat(avatar): add styles for soft shape in ionic theme #29552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
May 23, 2024
| </style> | ||
|
|
||
| <div id="container"> | ||
| <ion-avatar shape="soft" size="xsmall">AB</ion-avatar> |
There was a problem hiding this comment.
I added the xsmall and small sizes to this shape's tests only because it has a different border radius than the other sizes.
BenOsodrac
approved these changes
May 24, 2024
OS-giulianasilva
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Avatar does not have styles for the
"soft"shape in the ionic theme.What is the new behavior?
xsmallandsmallsizes have a different border radius than the larger sizesDoes this introduce a breaking change?
Other information
Preview