Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(item): add styles for default size in ionic theme #29559

Merged
merged 19 commits into from
Jun 3, 2024
Merged

feat(item): add styles for default size in ionic theme #29559

merged 19 commits into from
Jun 3, 2024

Conversation

rugoncalves
Copy link

@rugoncalves rugoncalves commented May 28, 2024 •
edited by brandyscarney
Loading

Issue number: internal

What is the new behavior?

  • Added scss for the ion-item for the Ionic theme
  • Added test page

Does this introduce a breaking change?

  • Yes
  • No

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 3:34pm

@github-actions github-actions bot added the package: core @ionic/core package label May 28, 2024
@rugoncalves rugoncalves changed the title ROU-10762: adding ionic theme to ion-item feat(ion-item): add ionic theme to ion-item May 28, 2024
@rugoncalves rugoncalves added the type: feature request a new feature, enhancement, or improvement label May 28, 2024
@rugoncalves rugoncalves marked this pull request as ready for review May 28, 2024 15:30
@rugoncalves rugoncalves requested a review from a team as a code owner May 28, 2024 15:30
@rugoncalves rugoncalves requested a review from gnbm May 28, 2024 15:30
BenOsodrac
BenOsodrac requested changes May 28, 2024
View reviewed changes
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
BenOsodrac
BenOsodrac requested changes May 29, 2024
View reviewed changes
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
@brandyscarney brandyscarney self-requested a review May 29, 2024 13:56
brandyscarney
brandyscarney requested changes May 29, 2024
View reviewed changes
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
core/src/components/item/item.ionic.scss Outdated Show resolved Hide resolved
@brandyscarney brandyscarney changed the title feat(ion-item): add ionic theme to ion-item feat(item): add styles for default size in ionic theme May 29, 2024
brandyscarney
brandyscarney approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@rugoncalves rugoncalves merged commit 1e7e21f into ionic-team:next Jun 3, 2024
46 checks passed
@rugoncalves rugoncalves deleted the ROU-10762 branch June 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rugoncalves @brandyscarney @BenOsodrac