Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(chip): use the new tokens #29565

Merged
merged 2 commits into from
May 30, 2024
Merged

refactor(chip): use the new tokens #29565

merged 2 commits into from
May 30, 2024

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 29, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Replaced old fixed values with new tokens.
  • Added theme="ionic" to ionic test page.

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels May 29, 2024
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 29, 2024 16:49
@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 4:51pm

@thetaPC
Copy link
Contributor

thetaPC commented May 29, 2024

@BenOsodrac this would be considered a refactor instead of a a feat since we are not introducing nothing new. I also recommend to update the PR title to refactor(chip): use the new tokens

thetaPC
thetaPC approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac changed the title feat(chip): review ionic chip scss and tokens usage refactor(chip): use the new tokens May 30, 2024
@BenOsodrac BenOsodrac merged commit eb7585e into next May 30, 2024
48 checks passed
@BenOsodrac BenOsodrac deleted the review-chip-css branch May 30, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@OS-giulianasilva OS-giulianasilva Awaiting requested review from OS-giulianasilva OS-giulianasilva is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BenOsodrac @thetaPC